-
Notifications
You must be signed in to change notification settings - Fork 842
Fix nonnull warning in uri_signing unit tests #12614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bryancall
wants to merge
3
commits into
master
Choose a base branch
from
fix-fedora41-uri-signing-nonnull
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nullptr check before strcmp to satisfy GCC's -Werror=nonnull warning. The expected_strip parameter can be nullptr in some test cases, so we need to check for null before passing to strcmp. This fixes the Fedora 41 gcc release build failure.
bneradt
requested changes
Oct 24, 2025
When expected_strip is nullptr, the test expects that the paramName value should be empty (i.e., no parameter was extracted from the URI). Add a check to verify uri_strip is indeed empty in this case.
bneradt
previously approved these changes
Oct 25, 2025
Contributor
bneradt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
JosiahWI
reviewed
Oct 27, 2025
JosiahWI
previously approved these changes
Oct 27, 2025
Remove early cjose_jws_release calls that caused double-free when validation failed. The function already releases jws unconditionally at the end, so the early releases on the error paths resulted in freeing the same pointer twice. This was a pre-existing bug in the strcmp path and was replicated in the new nullptr check path added in the previous commit.
JosiahWI
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Fedora 41 gcc release build failure.
Add
nullptrcheck beforestrcmpto satisfy GCC's-Werror=nonnullwarning. Theexpected_stripparameter can benullptrin some test cases (lines 325, 330, 362, 371, 376), so we need to check for null before passing tostrcmp.Error:
Affected Builds: